Bug 233830

Summary: [JSC] Add LLInt IC for try_get_by_id of own cacheable value
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Ross Kirsling 2021-12-03 11:07:37 PST 
[JSC] Add LLInt IC for try_get_by_id of own cacheable value
Comment 1 Ross Kirsling 2021-12-03 11:15:24 PST 
Created attachment 445877 [details]
Patch
Comment 2 Ross Kirsling 2021-12-03 13:48:13 PST 
Created attachment 445894 [details]
Patch

rebased
Comment 3 Yusuke Suzuki 2021-12-07 15:04:56 PST 
Comment on attachment 445894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445894&action=review

> Source/JavaScriptCore/bytecode/BytecodeList.rb:526
> +        structureID: StructureID,

StructureID is heap pointer (somewhat). So you need to consider about GC.
So, you need to add handling to CodeBlock::finalizeLLIntInlineCaches.
Comment 4 Yusuke Suzuki 2021-12-07 15:10:31 PST 
Comment on attachment 445894 [details]
Patch

Looks good overall, but I think we have GC issue, so r- for now.
Comment 5 Ross Kirsling 2021-12-07 16:01:21 PST 
Created attachment 446247 [details]
Patch
Comment 6 Yusuke Suzuki 2021-12-07 16:03:44 PST 
Comment on attachment 446247 [details]
Patch

r=me
Comment 7 EWS 2021-12-07 17:44:45 PST 
Committed r286635 (244948@main): <https://commits.webkit.org/244948@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446247 [details].
Comment 8 Radar WebKit Bug Importer 2021-12-07 17:45:21 PST 
<rdar://problem/86185467>