Bug 233830

Summary: [JSC] Add LLInt IC for try_get_by_id of own cacheable value
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Ross Kirsling
Reported 2021-12-03 11:07:37 PST
[JSC] Add LLInt IC for try_get_by_id of own cacheable value
Attachments
Patch (7.19 KB, patch)
2021-12-03 11:15 PST, Ross Kirsling 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (7.15 KB, patch)
2021-12-03 13:48 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (10.33 KB, patch)
2021-12-07 16:01 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2021-12-03 11:15:24 PST
Created attachment 445877 [details] Patch
Ross Kirsling
Comment 2 2021-12-03 13:48:13 PST
Created attachment 445894 [details] Patch rebased
Yusuke Suzuki
Comment 3 2021-12-07 15:04:56 PST
Comment on attachment 445894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445894&action=review > Source/JavaScriptCore/bytecode/BytecodeList.rb:526 > + structureID: StructureID, StructureID is heap pointer (somewhat). So you need to consider about GC. So, you need to add handling to CodeBlock::finalizeLLIntInlineCaches.
Yusuke Suzuki
Comment 4 2021-12-07 15:10:31 PST
Comment on attachment 445894 [details] Patch Looks good overall, but I think we have GC issue, so r- for now.
Ross Kirsling
Comment 5 2021-12-07 16:01:21 PST
Created attachment 446247 [details] Patch
Yusuke Suzuki
Comment 6 2021-12-07 16:03:44 PST
Comment on attachment 446247 [details] Patch r=me
EWS
Comment 7 2021-12-07 17:44:45 PST
Committed r286635 (244948@main): <https://commits.webkit.org/244948@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446247 [details].
Radar WebKit Bug Importer
Comment 8 2021-12-07 17:45:21 PST
<rdar://problem/86185467>
Note You need to log in before you can comment on or make changes to this bug.