Bug 233803

Summary: Rename DerivedSources/WebKit2 to DerivedSources/WebKit
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ap, ews-watchlist, glenn, gyuyoung.kim, jbedard, jenner, ryuan.choi, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233881
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Myles C. Maxfield
Reported 2021-12-03 00:21:54 PST
Rename DerivedSources/WebKit2 to DerivedSources/WebKit
Attachments
Patch (341.62 KB, patch)
2021-12-03 00:23 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (340.16 KB, patch)
2021-12-03 00:29 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (450.78 KB, patch)
2021-12-04 04:05 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (452.87 KB, patch)
2021-12-04 17:40 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-12-03 00:23:54 PST
Created attachment 445818 [details] Patch
Tim Horton
Comment 2 2021-12-03 00:27:40 PST
Good luck with the conflicts :)
Myles C. Maxfield
Comment 3 2021-12-03 00:29:59 PST
Created attachment 445819 [details] Patch
Tim Horton
Comment 4 2021-12-03 01:17:28 PST
Comment on attachment 445819 [details] Patch rs=me
EWS
Comment 5 2021-12-03 01:31:43 PST
Committed r286487 (244826@main): <https://commits.webkit.org/244826@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445819 [details].
Radar WebKit Bug Importer
Comment 6 2021-12-03 01:32:21 PST
<rdar://problem/86009014>
Robert Jenner
Comment 7 2021-12-03 12:24:00 PST
Reverted r286487 for reason: Broke multiple builds. Committed r286508 (244846@main): <https://commits.webkit.org/244846@main>
Myles C. Maxfield
Comment 8 2021-12-04 04:05:34 PST
Created attachment 445966 [details] Patch
Myles C. Maxfield
Comment 9 2021-12-04 17:40:09 PST
Created attachment 445972 [details] Patch
Myles C. Maxfield
Comment 10 2021-12-04 19:36:38 PST
Comment on attachment 445972 [details] Patch Okay, I made sure this builds correctly on Apple's internal build system and for OpenSource builds. I think this is ready to go.
EWS
Comment 11 2021-12-04 19:52:03 PST
Committed r286535 (244867@main): <https://commits.webkit.org/244867@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445972 [details].
Note You need to log in before you can comment on or make changes to this bug.