Bug 233737 – [Gstreamer] test http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html fails

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Arcady Goldmints-Orlov]

In r284365 the test http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html was fixed to give some more time to the frequency analyzer to detect activity. The same fix needs to be applied to http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html

[Arcady Goldmints-Orlov]

Created attachment 445637 [details]
Patch

[Philippe Normand]

I'm not sure adding a new timer is the solution here, it might just make the test flaky :(

[Enrique Ocaña]

In a 40 cores machine loaded with "stress -c 400" (10 times more than what the machine can process, showing a load of 395 when running top) the loop that samples the frequency data every 30 ms usually doesn't need extra iterations to get non-silence values. I ran the test (modified to end one second later on purpose) several times and I think only once or twice I got the need of one or two extra iterations at most.

100 ms would allow 3 extra iterations of the frequency sampler. I think that's enough, even on a loaded machine. If I was a reviewer (I'm not), I would accept the patch as is and increase the timeout if the test ever fails (flakes) again.

[Philippe Normand]

Comment on attachment 445637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445637&action=review

> LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html:46
> +	    }, 100);

ok then please fix indentation here and you'll get the r+ you deserve

[Arcady Goldmints-Orlov]

Created attachment 445749 [details]
Patch

[EWS]

Committed r286486 (244825@main): <https://commits.webkit.org/244825@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445749 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86008091>