Bug 233726

Summary:

REGRESSION: r286075 [ Big Sur x86] 2 TestWebKitAPI.WebPushD (API-Tests) are constant failures

Product:

WebKit

Reporter:

Robert Jenner <jenner>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=233295
https://bugs.webkit.org/show_bug.cgi?id=233679

Attachments:

Description	Flags
Patch	none

Robert Jenner

Reported 2021-12-01 14:31:41 PST

TestWebKitAPI.WebPushD.BasicCommunication TestWebKitAPI.WebPushD.PermissionManagement Are constant failures on BigSur Intel Macs only. HISTORY: https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebPushD.BasicCommunication&test=TestWebKitAPI.WebPushD.PermissionManagement TestWebKitAPI.WebPushD.BasicCommunication Failure: /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:183 Value of: stringMatches Actual: false Expected: true TestWebKitAPI.WebPushD.PermissionManagement Failure: /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:298 Expected equality of these values: [origins count] Which is: 0 1u Which is: 1 /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:305 Value of: [origin.get().protocol isEqualToString:@"testing"] Actual: false Expected: true /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:306 Value of: [origin.get().host isEqualToString:@"main"] Actual: false Expected: true

Attachments
Patch (3.59 KB, patch) 2021-12-02 10:38 PST, Brady Eidson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-12-01 14:32:40 PST

<rdar://problem/85940164>

Robert Jenner

Comment 2 2021-12-01 14:35:28 PST

The initial regression point that broke these tests for Big Sur Intel only was r286075 However, it also appears that r286355 broke "TestWebKitAPI.WebPushD.BasicCommunication " everywhere else. There are mixed Failures/Timeouts on BigSur, and iOS 15

Brady Eidson

Comment 3 2021-12-02 10:35:59 PST

Fixing the truly broken test on all platforms, and also disabling on Mac.

Brady Eidson

Comment 4 2021-12-02 10:38:39 PST

Created attachment 445739 [details] Patch

EWS

Comment 5 2021-12-02 11:39:49 PST

Committed r286440 (244784@main): <https://commits.webkit.org/244784@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445739 [details].

Note You need to log in before you can comment on or make changes to this bug.