Bug 233694

Summary: [GTK][a11y] Add implementation of table and table cell interfaces when building with ATSPI
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230253    
Attachments:
Description Flags
Patch aperez: review+

Carlos Garcia Campos
Reported 2021-12-01 04:25:49 PST
Implement table and table cell
Attachments
Patch (75.61 KB, patch)
2021-12-01 04:29 PST, Carlos Garcia Campos
aperez: review+
Carlos Garcia Campos
Comment 1 2021-12-01 04:29:13 PST
Adrian Perez
Comment 2 2021-12-01 05:45:44 PST
Comment on attachment 445554 [details] Patch Other than changing a few pointer literals to “nulptr” before landing, patch LGTM. View in context: https://bugs.webkit.org/attachment.cgi?id=445554&action=review > Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1069 > + return JSStringCreateWithCharacters(0, 0); While changing this you could replace the first zero with nullptr: return JSStringCreateWithCharacters(nullptr, 0); =] > Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1078 > + return JSStringCreateWithCharacters(0, 0); Same here: s/0/nullptr > Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1092 > + return JSStringCreateWithCharacters(0, 0); ...and here... > Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1101 > + return JSStringCreateWithCharacters(0, 0); ...one more... > Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1146 > + return JSStringCreateWithCharacters(0, 0); ...and another... (okay, I will stop commenting now on each of those)
Carlos Garcia Campos
Comment 3 2021-12-02 00:16:25 PST
Note You need to log in before you can comment on or make changes to this bug.