Summary: | [Win] OSAllocator::reserveUncommittedAligned should use aligned allocation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | Web Template Framework | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, don.olmstead, ews-watchlist, keith_miller, ross.kirsling, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Fujii Hironori
2021-11-30 18:14:30 PST
The document of VirtualAlloc2 has a sample code. "Scenario 3. Allocate memory in a specific virtual address range (below 4GB, in this example) and with specific alignment." https://docs.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualalloc2 Created attachment 445508 [details]
Patch
Comment on attachment 445508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445508&action=review > Source/WTF/wtf/win/OSAllocatorWin.cpp:69 > // FIXME: Is there a way to do this where we can either release the excess reservation or not reserve it at all? Nit: I'd remove this FIXME at this point. Created attachment 445603 [details]
Patch for landing
Thank you for the review.
Committed r286377 (244736@main): <https://commits.webkit.org/244736@main> |