Bug 233666

Summary:

[LBSE] Rename RenderSVGRoot -> LegacyRenderSVGRoot

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

SVG

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, changseok, dino, dmazzoni, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, hi, jcraig, jdiggs, joepeck, kondapallykalyan, pangle, pdr, rbuis, sabouhallawa, samuel_white, schenney, sergio, simon.fraser, webkit-bug-importer, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

233211

Bug Blocks:

90738, 233863, 233870

Attachments:

Description	Flags
Patch, v1	rbuis: review+

Description Nikolas Zimmermann 2021-11-30 15:33:18 PST

Let's start with moving RenderSVGRoot -> LegacyRenderSVGRoot.
A follow-up patch will introduce the new RenderSVGRoot stub implementation. After that switching from LBSE to legacy engine and back has a visual effect (LBSE enabled == nothing renderered).

After some experimentation on how to upstream, I found that starting from a clean RenderSVGRoot is the easiest approach.

Comment 1 Nikolas Zimmermann 2021-11-30 15:45:01 PST

Created attachment 445481 [details]
Patch, v1

Comment 2 Nikolas Zimmermann 2021-12-01 15:52:37 PST

Committed r286392 (244748@main): <https://commits.webkit.org/244748@main>

Comment 3 Radar WebKit Bug Importer 2021-12-01 15:53:24 PST

<rdar://problem/85943424>