Bug 233648

Summary: Move Subspaces from VM to Heap.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, annulen, beidson, cdumez, ews-watchlist, gyuyoung.kim, hi, joepeck, jsbell, keith_miller, msaboff, pangle, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232849    
Attachments:
Description Flags
proposed patch.
saam: review+, ews-feeder: commit-queue-
patch for landing.
ews-feeder: commit-queue-
patch for landing + speculative fix for Windows build. none

Mark Lam
Reported 2021-11-30 11:16:11 PST
Subspaces are Heap data structures to begin with, and this refactoring is needed in preparation for the global GC.
Attachments
proposed patch. (420.51 KB, patch)
2021-11-30 14:06 PST, Mark Lam 		saam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing. (421.16 KB, patch)
2021-11-30 14:52 PST, Mark Lam 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing + speculative fix for Windows build. (421.54 KB, patch)
2021-11-30 16:18 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-30 11:17:12 PST
<rdar://problem/85875751>
Mark Lam
Comment 2 2021-11-30 14:06:03 PST
Created attachment 445469 [details] proposed patch.
Saam Barati
Comment 3 2021-11-30 14:44:06 PST
Comment on attachment 445469 [details] proposed patch. r=me
Mark Lam
Comment 4 2021-11-30 14:52:32 PST
Created attachment 445472 [details] patch for landing. Thanks for the review. This patch also includes a fix for the watchOS EWS build failure.
Mark Lam
Comment 5 2021-11-30 16:18:29 PST
Created attachment 445484 [details] patch for landing + speculative fix for Windows build.
Mark Lam
Comment 6 2021-11-30 20:39:56 PST
Landed in r286347: <http://trac.webkit.org/r286347>.
Note You need to log in before you can comment on or make changes to this bug.