Bug 233648

Summary:

Move Subspaces from VM to Heap.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, annulen, beidson, cdumez, ews-watchlist, gyuyoung.kim, hi, joepeck, jsbell, keith_miller, msaboff, pangle, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

232849

Attachments:

Description	Flags
proposed patch.	saam: review+, ews-feeder: commit-queue-
patch for landing.	ews-feeder: commit-queue-
patch for landing + speculative fix for Windows build.	none

Description Mark Lam 2021-11-30 11:16:11 PST

Subspaces are Heap data structures to begin with, and this refactoring is needed in preparation for the global GC.

Comment 1 Radar WebKit Bug Importer 2021-11-30 11:17:12 PST

<rdar://problem/85875751>

Comment 2 Mark Lam 2021-11-30 14:06:03 PST

Created attachment 445469 [details]
proposed patch.

Comment 3 Saam Barati 2021-11-30 14:44:06 PST

Comment on attachment 445469 [details]
proposed patch.

r=me

Comment 4 Mark Lam 2021-11-30 14:52:32 PST

Created attachment 445472 [details]
patch for landing.

Thanks for the review.  This patch also includes a fix for the watchOS EWS build failure.

Comment 5 Mark Lam 2021-11-30 16:18:29 PST

Created attachment 445484 [details]
patch for landing + speculative fix for Windows build.

Comment 6 Mark Lam 2021-11-30 20:39:56 PST

Landed in r286347: <http://trac.webkit.org/r286347>.