| Summary: | Add a fast path for empty string to setInnerHTML() | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||||||
| Component: | DOM | Assignee: | Alexey Shvayka <ashvayka> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, clopez, cmarcelo, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer, youennf, ysuzuki | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| See Also: | https://github.com/web-platform-tests/wpt/pull/31844 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alexey Shvayka
2021-11-30 11:01:15 PST
Created attachment 445444 [details]
Patch
Created attachment 445445 [details] Microbenchmark r286261: 393ms patched: 110ms (3.6x faster) Comment on attachment 445444 [details]
Patch
r=me
Nice!
Created attachment 445578 [details]
Patch
Special-case <html> container.
NICE! Can we add a test for this HTMLElement thing? (In reply to Yusuke Suzuki from comment #5) > NICE! Can we add a test for this HTMLElement thing? Thanks! You mean for the <html> thing? imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_tests_innerHTML_1.html captures that. (In reply to Alexey Shvayka from comment #6) > (In reply to Yusuke Suzuki from comment #5) > > NICE! Can we add a test for this HTMLElement thing? > > Thanks! You mean for the <html> thing? > imported/w3c/web-platform-tests/html/syntax/parsing/ > html5lib_innerHTML_tests_innerHTML_1.html captures that. Perfect! Created attachment 445596 [details]
Patch
Fix <template> contents case and add a test.
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Comment on attachment 445596 [details]
Patch
Setting r+ on my own patch, which is already reviewed by Geoff, to make GitHub WPT export bot happy.
Committed r286425 (244771@main): <https://commits.webkit.org/244771@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445596 [details]. |