Bug 233647

Summary: Add a fast path for empty string to setInnerHTML()
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: DOMAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, clopez, cmarcelo, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer, youennf, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://github.com/web-platform-tests/wpt/pull/31844
Attachments:
Description Flags
Patch
none
Microbenchmark
none
Patch
none
Patch none

Alexey Shvayka
Reported 2021-11-30 11:01:15 PST
Add a fast path for empty string to setInnerHTML()
Attachments
Patch (2.85 KB, patch)
2021-11-30 11:02 PST, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Microbenchmark (792 bytes, text/html)
2021-11-30 11:03 PST, Alexey Shvayka 		no flags
Details
Patch (3.41 KB, patch)
2021-12-01 08:43 PST, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (7.05 KB, patch)
2021-12-01 11:26 PST, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2021-11-30 11:02:49 PST
Created attachment 445444 [details] Patch
Alexey Shvayka
Comment 2 2021-11-30 11:03:50 PST
Created attachment 445445 [details] Microbenchmark r286261: 393ms patched: 110ms (3.6x faster)
Geoffrey Garen
Comment 3 2021-11-30 11:36:43 PST
Comment on attachment 445444 [details] Patch r=me Nice!
Alexey Shvayka
Comment 4 2021-12-01 08:43:40 PST
Created attachment 445578 [details] Patch Special-case <html> container.
Yusuke Suzuki
Comment 5 2021-12-01 09:53:16 PST
NICE! Can we add a test for this HTMLElement thing?
Alexey Shvayka
Comment 6 2021-12-01 09:56:44 PST
(In reply to Yusuke Suzuki from comment #5) > NICE! Can we add a test for this HTMLElement thing? Thanks! You mean for the <html> thing? imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_tests_innerHTML_1.html captures that.
Yusuke Suzuki
Comment 7 2021-12-01 10:04:18 PST
(In reply to Alexey Shvayka from comment #6) > (In reply to Yusuke Suzuki from comment #5) > > NICE! Can we add a test for this HTMLElement thing? > > Thanks! You mean for the <html> thing? > imported/w3c/web-platform-tests/html/syntax/parsing/ > html5lib_innerHTML_tests_innerHTML_1.html captures that. Perfect!
Alexey Shvayka
Comment 8 2021-12-01 11:26:25 PST
Created attachment 445596 [details] Patch Fix <template> contents case and add a test.
EWS Watchlist
Comment 9 2021-12-01 11:27:13 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Alexey Shvayka
Comment 10 2021-12-02 06:42:35 PST
Comment on attachment 445596 [details] Patch Setting r+ on my own patch, which is already reviewed by Geoff, to make GitHub WPT export bot happy.
EWS
Comment 11 2021-12-02 07:21:22 PST
Committed r286425 (244771@main): <https://commits.webkit.org/244771@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445596 [details].
Radar WebKit Bug Importer
Comment 12 2021-12-02 07:22:23 PST
<rdar://problem/85970175>
Note You need to log in before you can comment on or make changes to this bug.