Bug 233601

Summary: html/semantics/forms/constraints/form-validation-validity-patternMismatch.html WPT test is failing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: FormsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, changseok, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, mifenton, sam, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 233428    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-11-29 15:32:37 PST
html/semantics/forms/constraints/form-validation-validity-patternMismatch.html WPT test is failing in WebKit but passing in Blink & Gecko.
Attachments
Patch (17.17 KB, patch)
2021-11-29 15:37 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.58 KB, patch)
2021-11-29 16:53 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.45 KB, patch)
2021-11-30 07:49 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.47 KB, patch)
2021-11-30 10:35 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-11-29 15:37:28 PST
Created attachment 445355 [details] Patch
Chris Dumez
Comment 2 2021-11-29 16:53:00 PST
Created attachment 445365 [details] Patch
Chris Dumez
Comment 3 2021-11-30 07:49:08 PST
Created attachment 445417 [details] Patch
Darin Adler
Comment 4 2021-11-30 09:12:31 PST
Comment on attachment 445417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445417&action=review > Source/WebCore/html/BaseTextInputType.cpp:46 > + String pattern = makeString("^(?:", rawPattern, ")$"); I’d think we’d want to create and capture a single Yarr::RegularExpression and re-use it to make the findMatching loop more efficient.
Chris Dumez
Comment 5 2021-11-30 10:35:34 PST
Created attachment 445437 [details] Patch
EWS
Comment 6 2021-11-30 12:38:34 PST
Committed r286315 (244674@main): <https://commits.webkit.org/244674@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445437 [details].
Radar WebKit Bug Importer
Comment 7 2021-11-30 12:39:23 PST
<rdar://problem/85881537>
Note You need to log in before you can comment on or make changes to this bug.