Bug 233601

Summary: html/semantics/forms/constraints/form-validation-validity-patternMismatch.html WPT test is failing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: FormsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, changseok, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, mifenton, sam, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 233428    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2021-11-29 15:32:37 PST 
html/semantics/forms/constraints/form-validation-validity-patternMismatch.html WPT test is failing in WebKit but passing in Blink & Gecko.
Comment 1 Chris Dumez 2021-11-29 15:37:28 PST 
Created attachment 445355 [details]
Patch
Comment 2 Chris Dumez 2021-11-29 16:53:00 PST 
Created attachment 445365 [details]
Patch
Comment 3 Chris Dumez 2021-11-30 07:49:08 PST 
Created attachment 445417 [details]
Patch
Comment 4 Darin Adler 2021-11-30 09:12:31 PST 
Comment on attachment 445417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445417&action=review

> Source/WebCore/html/BaseTextInputType.cpp:46
> +    String pattern = makeString("^(?:", rawPattern, ")$");

I’d think we’d want to create and capture a single Yarr::RegularExpression and re-use it to make the findMatching loop more efficient.
Comment 5 Chris Dumez 2021-11-30 10:35:34 PST 
Created attachment 445437 [details]
Patch
Comment 6 EWS 2021-11-30 12:38:34 PST 
Committed r286315 (244674@main): <https://commits.webkit.org/244674@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445437 [details].
Comment 7 Radar WebKit Bug Importer 2021-11-30 12:39:23 PST 
<rdar://problem/85881537>