Bug 233594

Summary:

[WP] Sandbox telemetry is missing for some system calls

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, gavin.p, mazander, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	bfulgham: review+, ews-feeder: commit-queue-
Patch	none

Per Arne Vollan

Reported 2021-11-29 13:35:36 PST

Sandbox telemetry is missing for some system calls, since telemetry rules are automatically overridden in some cases.

Attachments
Patch (6.85 KB, patch) 2021-11-29 13:45 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (4.23 KB, patch) 2021-11-30 15:32 PST, Per Arne Vollan	bfulgham: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.28 KB, patch) 2021-12-01 12:10 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-11-29 13:36:20 PST

<rdar://problem/85832755>

Per Arne Vollan

Comment 2 2021-11-29 13:45:11 PST

Created attachment 445335 [details] Patch

Brent Fulgham

Comment 3 2021-11-29 14:39:39 PST

Comment on attachment 445335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445335&action=review r=me > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:1196 > +(disable-syscall-inference) Do we have a similar issue on macOS we should address?

Per Arne Vollan

Comment 4 2021-11-29 14:43:47 PST

(In reply to Brent Fulgham from comment #3) > Comment on attachment 445335 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445335&action=review > > r=me > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:1196 > > +(disable-syscall-inference) > > Do we have a similar issue on macOS we should address? Ah, yes, that is a good point. I will address that in a follow-up patch. Thanks for reviewing!

EWS

Comment 5 2021-11-29 15:10:44 PST

Committed r286266 (244629@main): <https://commits.webkit.org/244629@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445335 [details].

Per Arne Vollan

Comment 6 2021-11-30 15:32:56 PST

Created attachment 445477 [details] Patch

Brent Fulgham

Comment 7 2021-11-30 15:43:54 PST

Comment on attachment 445477 [details] Patch r=me

Per Arne Vollan

Comment 8 2021-11-30 16:02:29 PST

Comment on attachment 445477 [details] Patch Thanks for reviewing!

Per Arne Vollan

Comment 9 2021-11-30 20:59:13 PST

Reopened after attaching new patch.

EWS

Comment 10 2021-11-30 23:08:16 PST

Found 30 new test failures: accessibility/ARIA-reflection.html, accessibility/accessibility-crash-focused-element-change.html, accessibility/accessibility-crash-setattribute.html, accessibility/mac/abbr-acronym-tags.html, accessibility/mac/accessibility-make-first-responder.html, accessibility/mac/attributed-string/attributed-string-for-range-with-options.html, accessibility/mac/attributed-string/attributed-string-for-range.html, accessibility/mac/search-text/search-text.html, accessibility/mac/select-text/select-text-1.html, accessibility/mac/select-text/select-text-2.html ...

Per Arne Vollan

Comment 11 2021-12-01 12:10:17 PST

Created attachment 445602 [details] Patch

EWS

Comment 12 2021-12-01 13:19:04 PST

Committed r286381 (244740@main): <https://commits.webkit.org/244740@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445602 [details].

Note You need to log in before you can comment on or make changes to this bug.