| Summary: | Integrate accelerated rendering into RenderLayer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarrin, dino, hyatt | ||||
| Priority: | P1 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 23359 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2009-01-15 14:55:29 PST
Created attachment 27267 [details]
Patch, changelog.
Comment on attachment 27267 [details]
Patch, changelog.
I don't think you need to null check viww() in compositor().
Remove the font smoothing stuff from RenderLayer. That needs more discussion.
Since you complicated the syncing because of lists being dirty, maybe you could pull that into a new function.. updateLayerListsIfNeeded or something.
Don't just comment out result.move(m_x, m_y). Take it out in both places.
You should use an OwnPtr for m_backing.
Remove the CSSPropertyNames.h include from RenderLayer.h
The implementation of transparentAncestor is broken. You want to walk until you hit a layer with isComposited set, and if you encounter a transparent layer before then, return it. Otherwise return 0. It should also probably be renamed to something like transparentPaintingAncestor.
r=me making all these changes.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderLayer.cpp M WebCore/rendering/RenderLayer.h Committed r40544 |