| Summary: | [JSC] Add Intl.NumberFormat.formatRangeToParts | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 218829 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2021-11-27 23:11:00 PST
Created attachment 445234 [details]
Patch
Created attachment 445248 [details]
Patch
Created attachment 445249 [details]
Patch
Comment on attachment 445249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445249&action=review r=me, very nice. > Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:1511 > + auto partValue = jsSubstring(vm, formatted, field.m_range.begin(), field.m_range.end() - field.m_range.begin()); Wonder if we should add a method to WTF::Range for this? Comment on attachment 445249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445249&action=review >> Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:1511 >> + auto partValue = jsSubstring(vm, formatted, field.m_range.begin(), field.m_range.end() - field.m_range.begin()); > > Wonder if we should add a method to WTF::Range for this? Added Range::distance method, which is aligned to STL's naming (begin, end, distance). Committed r286255 (244618@main): <https://commits.webkit.org/244618@main> |