Bug 23353

Summary:

build fix for ThreadingPthreads.cpp

Product:

WebKit

Reporter:

Daniel Mack <webkit>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Trivial

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
include #limits.h to make the built succeed	none
include #limits.h to make the built succeed	none

Description Daniel Mack 2009-01-15 12:01:53 PST

The current svn HEAD does not compile on a Debian/unstable box due to the following reason. The attached patch fixes that trivial problem.

../../JavaScriptCore/wtf/ThreadingPthreads.cpp: In member function ‘bool WTF::ThreadCondition::timedWait(WTF::Mutex&, double)’:
../../JavaScriptCore/wtf/ThreadingPthreads.cpp:241: error: ‘INT_MAX’ was not declared in this scope
make[1]: *** [JavaScriptCore/wtf/libJavaScriptCore_la-ThreadingPthreads.lo] Error 1
make[1]: Leaving directory `/home/daniel/src/WebKit/WebKit/WebKitBuild/Release'
make: *** [all] Error 2

Failed to build WebKit using 'make'!

Comment 1 Daniel Mack 2009-01-15 12:03:35 PST

Created attachment 26765 [details]
include #limits.h to make the built succeed

Comment 2 Daniel Mack 2009-01-15 12:12:52 PST

Comment on attachment 26765 [details]
include #limits.h to make the built succeed

superseeded by 2nd patch - ignore this one

Comment 3 Daniel Mack 2009-01-15 12:13:26 PST

Created attachment 26767 [details]
include #limits.h to make the built succeed

Comment 4 Holger Freyther 2009-01-15 12:22:15 PST

Comment on attachment 26767 [details]
include #limits.h to make the built succeed

Okay, I will add a reference to the bug URL in the changelog.

Comment 5 Darin Adler 2009-01-15 13:05:51 PST


*** This bug has been marked as a duplicate of 23347 ***

Comment 6 Darin Adler 2009-01-15 13:06:26 PST

Comment on attachment 26767 [details]
include #limits.h to make the built succeed

There's an already-reviewed patch in another bug. Someone just needs to land it.