Bug 233527

Summary: [CSS Color 5] Update color-mix() to latest spec (again)
Product: WebKit Reporter: Sam Weinig <sam>
Component: CSSAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, heycam, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch none

Sam Weinig
Reported 2021-11-26 11:06:44 PST
color-mix() has been updated with support for specific hue interpolation methods based on the new <color-interpolation-method> construction https://drafts.csswg.org/css-color-4/#color-interpolation-method. Since <color-interpolation-method> is also been adopted for specifying CSS gradient interpolation (https://drafts.csswg.org/css-images-4/#gradients) so it would be good to make sure it is useable for both.
Attachments
WIP (56.02 KB, patch)
2021-11-27 11:12 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (100.96 KB, patch)
2021-11-27 20:51 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-11-27 11:12:37 PST Comment hidden (obsolete)
Sam Weinig
Comment 2 2021-11-27 20:51:45 PST
Created attachment 445230 [details] Patch
Sam Weinig
Comment 3 2021-11-27 20:52:56 PST
This addresses most of the changes. Still not addressed (and will be handled separately): - None/missing components (we need to support them first) - Alpha premultiplication (I need a bit more clarity on this)
EWS
Comment 4 2021-11-28 10:55:11 PST
Committed r286196 (244578@main): <https://commits.webkit.org/244578@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445230 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-28 10:56:20 PST
<rdar://problem/85788950>
Note You need to log in before you can comment on or make changes to this bug.