Bug 233522

Summary:

GraphicsContextGL should have ANGLE-specific subclass

Product:

WebKit

Reporter:

Kimmo Kinnunen <kkinnunen>

Component:

WebGL

Assignee:

Kimmo Kinnunen <kkinnunen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, cmarcelo, dino, don.olmstead, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, koivisto, kondapallykalyan, luiz, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

221664

Attachments:

Description	Flags
Patch	none
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch	none

Description Kimmo Kinnunen 2021-11-26 06:10:46 PST

GraphicsContextGL should have ANGLE-specific subclass

Currently ANGLE code is ifdefed in GraphicsContextGLOpenGL
Make class GraphicsContextGLANGLE  be about ANGLE.
Make class GraphicsContextGLOpenGL be about OpenGL, OpenGL ES.

Comment 1 Kimmo Kinnunen 2021-11-26 06:27:42 PST

Created attachment 445198 [details]
Patch

Comment 2 Antti Koivisto 2021-11-29 01:20:57 PST

Comment on attachment 445198 [details]
Patch

rs=me

Comment 3 Kimmo Kinnunen 2021-11-29 05:12:52 PST

Created attachment 445268 [details]
Patch for landing

Comment 4 Kimmo Kinnunen 2021-11-29 05:18:35 PST

Created attachment 445270 [details]
Patch for landing

Comment 5 Kimmo Kinnunen 2021-11-29 05:59:06 PST

Created attachment 445275 [details]
Patch for landing

Comment 6 Don Olmstead 2021-11-29 09:52:47 PST

It really feels like we should be trying to collapse into a single GraphicsContextGL not making more subclasses. Couldn't we just provide the same sort of namespaced gl:: functions but mapped to a system OpenGL ES and collapse things that way?

Comment 7 Kimmo Kinnunen 2021-11-29 11:06:52 PST

Created attachment 445300 [details]
Patch for landing

Comment 8 Kimmo Kinnunen 2021-11-29 11:20:21 PST

Created attachment 445306 [details]
Patch for landing

Comment 9 Kimmo Kinnunen 2021-11-29 11:56:41 PST

Created attachment 445317 [details]
Patch for landing

Comment 10 Kimmo Kinnunen 2021-11-29 23:00:13 PST

Created attachment 445382 [details]
Patch for landing

Comment 11 Kimmo Kinnunen 2021-11-29 23:21:31 PST

Created attachment 445385 [details]
Patch for landing

Comment 12 Kimmo Kinnunen 2021-11-29 23:53:15 PST

Created attachment 445388 [details]
Patch for landing

Comment 13 Kimmo Kinnunen 2021-11-30 00:41:54 PST

Created attachment 445391 [details]
Patch for landing

Comment 14 Kimmo Kinnunen 2021-11-30 01:04:57 PST

Created attachment 445393 [details]
Patch for landing

Comment 15 Kimmo Kinnunen 2021-11-30 01:33:31 PST

Created attachment 445395 [details]
Patch for landing

Comment 16 Kimmo Kinnunen 2021-11-30 02:12:27 PST

Created attachment 445399 [details]
Patch

Comment 17 EWS 2021-11-30 06:55:01 PST

Committed r286293 (244652@main): <https://commits.webkit.org/244652@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445399 [details].

Comment 18 Radar WebKit Bug Importer 2021-11-30 06:56:29 PST

<rdar://problem/85863502>