Bug 233522

Summary:

GraphicsContextGL should have ANGLE-specific subclass

Product:

WebKit

Reporter:

Kimmo Kinnunen <kkinnunen>

Component:

WebGL

Assignee:

Kimmo Kinnunen <kkinnunen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, cmarcelo, dino, don.olmstead, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, koivisto, kondapallykalyan, luiz, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

221664

Attachments:

Description	Flags
Patch	none
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch	none

Kimmo Kinnunen

Reported 2021-11-26 06:10:46 PST

GraphicsContextGL should have ANGLE-specific subclass Currently ANGLE code is ifdefed in GraphicsContextGLOpenGL Make class GraphicsContextGLANGLE be about ANGLE. Make class GraphicsContextGLOpenGL be about OpenGL, OpenGL ES.

Attachments
Patch (533.46 KB, patch) 2021-11-26 06:27 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch for landing (532.04 KB, patch) 2021-11-29 05:12 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (531.79 KB, patch) 2021-11-29 05:18 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (542.46 KB, patch) 2021-11-29 05:59 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch for landing (542.45 KB, patch) 2021-11-29 11:06 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (559.54 KB, patch) 2021-11-29 11:20 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (559.71 KB, patch) 2021-11-29 11:56 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch for landing (560.12 KB, patch) 2021-11-29 23:00 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (563.64 KB, patch) 2021-11-29 23:21 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (563.63 KB, patch) 2021-11-29 23:53 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (563.97 KB, patch) 2021-11-30 00:41 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (564.27 KB, patch) 2021-11-30 01:04 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (564.09 KB, patch) 2021-11-30 01:33 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (564.12 KB, patch) 2021-11-30 02:12 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

Kimmo Kinnunen

Comment 1 2021-11-26 06:27:42 PST

Created attachment 445198 [details] Patch

Antti Koivisto

Comment 2 2021-11-29 01:20:57 PST

Comment on attachment 445198 [details] Patch rs=me

Kimmo Kinnunen

Comment 3 2021-11-29 05:12:52 PST

Created attachment 445268 [details] Patch for landing

Kimmo Kinnunen

Comment 4 2021-11-29 05:18:35 PST

Created attachment 445270 [details] Patch for landing

Kimmo Kinnunen

Comment 5 2021-11-29 05:59:06 PST

Created attachment 445275 [details] Patch for landing

Don Olmstead

Comment 6 2021-11-29 09:52:47 PST

It really feels like we should be trying to collapse into a single GraphicsContextGL not making more subclasses. Couldn't we just provide the same sort of namespaced gl:: functions but mapped to a system OpenGL ES and collapse things that way?

Kimmo Kinnunen

Comment 7 2021-11-29 11:06:52 PST

Created attachment 445300 [details] Patch for landing

Kimmo Kinnunen

Comment 8 2021-11-29 11:20:21 PST

Created attachment 445306 [details] Patch for landing

Kimmo Kinnunen

Comment 9 2021-11-29 11:56:41 PST

Created attachment 445317 [details] Patch for landing

Kimmo Kinnunen

Comment 10 2021-11-29 23:00:13 PST

Created attachment 445382 [details] Patch for landing

Kimmo Kinnunen

Comment 11 2021-11-29 23:21:31 PST

Created attachment 445385 [details] Patch for landing

Kimmo Kinnunen

Comment 12 2021-11-29 23:53:15 PST

Created attachment 445388 [details] Patch for landing

Kimmo Kinnunen

Comment 13 2021-11-30 00:41:54 PST

Created attachment 445391 [details] Patch for landing

Kimmo Kinnunen

Comment 14 2021-11-30 01:04:57 PST

Created attachment 445393 [details] Patch for landing

Kimmo Kinnunen

Comment 15 2021-11-30 01:33:31 PST

Created attachment 445395 [details] Patch for landing

Kimmo Kinnunen

Comment 16 2021-11-30 02:12:27 PST

Created attachment 445399 [details] Patch

EWS

Comment 17 2021-11-30 06:55:01 PST

Committed r286293 (244652@main): <https://commits.webkit.org/244652@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445399 [details].

Radar WebKit Bug Importer

Comment 18 2021-11-30 06:56:29 PST

<rdar://problem/85863502>

Note You need to log in before you can comment on or make changes to this bug.