Bug 233446

Summary: [selectors] Import 2 new :focus-visible tests from WPT
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: New BugsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, koivisto, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/31728
Bug Depends on:    
Bug Blocks: 221925    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2021-11-23 07:14:50 PST
[selectors] Import 2 new :focus-visible tests from WPT
Attachments
Patch (23.51 KB, patch)
2021-11-23 07:15 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (23.55 KB, patch)
2021-11-24 01:18 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (24.69 KB, patch)
2021-11-24 02:19 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2021-11-23 07:15:20 PST
Created attachment 445029 [details] Patch
Manuel Rego Casasnovas
Comment 2 2021-11-24 01:14:50 PST
The timeouts we're seeing clicking on the image are due to bug #233470. I'll tweak the test to avoid the timeout.
Manuel Rego Casasnovas
Comment 3 2021-11-24 01:18:19 PST
Created attachment 445081 [details] Patch
Manuel Rego Casasnovas
Comment 4 2021-11-24 02:19:35 PST
Created attachment 445083 [details] Patch
Antti Koivisto
Comment 5 2021-11-24 05:12:47 PST
Comment on attachment 445083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445083&action=review > LayoutTests/imported/w3c/ChangeLog:8 > + We're slightly tweaking the tests due to bug webkit.org/b/233470. Are you also updating the tweaks to WPT? We shouldn't be out of sync.
Manuel Rego Casasnovas
Comment 6 2021-11-24 05:39:31 PST
(In reply to Antti Koivisto from comment #5) > Comment on attachment 445083 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445083&action=review > > > LayoutTests/imported/w3c/ChangeLog:8 > > + We're slightly tweaking the tests due to bug webkit.org/b/233470. > > Are you also updating the tweaks to WPT? We shouldn't be out of sync. Yes, that's in the "See also" field: https://github.com/web-platform-tests/wpt/pull/31728 With the r+ here, it got automatically approved there, and I already merged it in WPT. Now let's land this in WebKit via cq.
EWS
Comment 7 2021-11-24 05:41:08 PST
Committed r286146 (244530@main): <https://commits.webkit.org/244530@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445083 [details].
Radar WebKit Bug Importer
Comment 8 2021-11-24 05:42:20 PST
<rdar://problem/85726464>
Note You need to log in before you can comment on or make changes to this bug.