| Summary: | [selectors] Import 2 new :focus-visible tests from WPT | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||
| Component: | New Bugs | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | clopez, ews-watchlist, koivisto, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://github.com/web-platform-tests/wpt/pull/31728 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 221925 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Manuel Rego Casasnovas
2021-11-23 07:14:50 PST
Created attachment 445029 [details]
Patch
The timeouts we're seeing clicking on the image are due to bug #233470. I'll tweak the test to avoid the timeout. Created attachment 445081 [details]
Patch
Created attachment 445083 [details]
Patch
Comment on attachment 445083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445083&action=review > LayoutTests/imported/w3c/ChangeLog:8 > + We're slightly tweaking the tests due to bug webkit.org/b/233470. Are you also updating the tweaks to WPT? We shouldn't be out of sync. (In reply to Antti Koivisto from comment #5) > Comment on attachment 445083 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445083&action=review > > > LayoutTests/imported/w3c/ChangeLog:8 > > + We're slightly tweaking the tests due to bug webkit.org/b/233470. > > Are you also updating the tweaks to WPT? We shouldn't be out of sync. Yes, that's in the "See also" field: https://github.com/web-platform-tests/wpt/pull/31728 With the r+ here, it got automatically approved there, and I already merged it in WPT. Now let's land this in WebKit via cq. Committed r286146 (244530@main): <https://commits.webkit.org/244530@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445083 [details]. |