Bug 233431

Summary: [WebGPU] Provide default values for descriptor struct members
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2021-11-22 13:38:43 PST
[WebGPU] Provide default values for descriptor struct members
Attachments
Patch (64.58 KB, patch)
2021-11-22 13:42 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (63.78 KB, patch)
2021-11-23 01:16 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-11-22 13:42:04 PST
Created attachment 444979 [details] Patch
Myles C. Maxfield
Comment 2 2021-11-23 01:16:26 PST
Created attachment 445017 [details] Patch
Alex Christensen
Comment 3 2021-11-29 10:17:57 PST
Comment on attachment 445017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445017&action=review > Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassColorAttachment.h:41 > + TextureView* resolveTarget { nullptr }; I'm not sure about the lifetime of this object, but we may consider making this a WeakPtr.
Myles C. Maxfield
Comment 4 2021-11-29 11:35:00 PST
Comment on attachment 445017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445017&action=review >> Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassColorAttachment.h:41 >> + TextureView* resolveTarget { nullptr }; > > I'm not sure about the lifetime of this object, but we may consider making this a WeakPtr. These objects are never stored, so I think a raw pointer is the right type to use.
EWS
Comment 5 2021-11-29 12:11:32 PST
Committed r286252 (244615@main): <https://commits.webkit.org/244615@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445017 [details].
Radar WebKit Bug Importer
Comment 6 2021-11-29 12:12:25 PST
<rdar://problem/85829191>
Note You need to log in before you can comment on or make changes to this bug.