Bug 233416

Summary: [WASM-GC] Add support for GC structs types encoding
Product: WebKit Reporter: Dmitry <dbezhetskov>
Component: WebAssemblyAssignee: Dmitry <dbezhetskov>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: asumu, bashorov, d_degazio, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 247394, 246981    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Dmitry
Reported 2021-11-22 02:18:39 PST
Wasm GC proposal introduces struct types in the MVP: https://github.com/WebAssembly/gc/blob/master/proposals/gc/MVP.md. So, this is a first step to support them - support encoding scheme.
Attachments
Patch (47.75 KB, patch)
2021-11-22 02:21 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (47.80 KB, patch)
2021-11-22 02:26 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (70.95 KB, patch)
2021-12-07 02:05 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (95.56 KB, patch)
2021-12-07 02:36 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (70.95 KB, patch)
2021-12-07 02:38 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Dmitry
Comment 1 2021-11-22 02:21:15 PST
Created attachment 444952 [details] Patch
EWS Watchlist
Comment 2 2021-11-22 02:22:07 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Dmitry
Comment 3 2021-11-22 02:26:12 PST
Created attachment 444953 [details] Patch
Radar WebKit Bug Importer
Comment 4 2021-11-29 02:19:24 PST
<rdar://problem/85804675>
Dmitry
Comment 5 2021-12-07 02:05:12 PST
Created attachment 446138 [details] Patch
Dmitry
Comment 6 2021-12-07 02:36:15 PST
Created attachment 446145 [details] Patch
Dmitry
Comment 7 2021-12-07 02:38:11 PST
Created attachment 446146 [details] Patch
Asumu Takikawa
Comment 8 2024-02-06 12:10:19 PST
I think we can likely close this bug now
David Degazio
Comment 9 2024-07-24 15:16:10 PDT
Yeah this looks pretty closable, we have had handling for WASM GC types and opcodes for months. Resolving as a dupe of https://bugs.webkit.org/show_bug.cgi?id=263026. *** This bug has been marked as a duplicate of bug 263026 ***
Note You need to log in before you can comment on or make changes to this bug.