Bug 233412

Summary:

[MSVC] RenderBlock.cpp(2259): warning C4239: nonstandard extension used: 'initializing': conversion from 'WebCore::Length' to 'WebCore::Length &'

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

Layout and Rendering

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, don.olmstead, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, svillar, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Fujii Hironori 2021-11-21 21:35:50 PST

[MSVC] RenderBlock.cpp(2259): warning C4239: nonstandard extension used: 'initializing': conversion from 'WebCore::Length' to 'WebCore::Length &'

WinCairo build reports the following warnings.

Source\WebCore\rendering/RenderBlock.cpp(2259): warning C4239: nonstandard extension used: 'initializing': conversion from 'WebCore::Length' to 'WebCore::Length &'
Source\WebCore\rendering/RenderBlock.cpp(2259): note: A non-const reference may only be bound to an lvalue
Source\WebCore\rendering/RenderBox.cpp(3116): warning C4239: nonstandard extension used: 'initializing': conversion from 'WebCore::Length' to 'WebCore::Length &'
Source\WebCore\rendering/RenderBox.cpp(3116): note: A non-const reference may only be bound to an lvalue

Comment 1 Fujii Hironori 2021-11-21 21:39:38 PST

Created attachment 444943 [details]
Patch

Comment 2 Fujii Hironori 2021-11-21 21:40:15 PST

Bug 230755 added the code.

Comment 3 EWS 2021-11-22 12:42:18 PST

Committed r286118 (244505@main): <https://commits.webkit.org/244505@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444943 [details].

Comment 4 Radar WebKit Bug Importer 2021-11-22 12:43:21 PST

<rdar://problem/85682648>