Bug 233356

Summary: [Model] add support for controlling looping animations
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, esprehn+autocc, ews-watchlist, kondapallykalyan, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch wenson_hsieh: review+

Description Antoine Quint 2021-11-19 02:43:47 PST 
[Model] add support for controlling looping animations
Comment 1 Antoine Quint 2021-11-19 02:45:42 PST 
Created attachment 444795 [details]
Patch
Comment 2 Antoine Quint 2021-11-19 02:45:48 PST 
<rdar://problem/85428884>
Comment 3 Wenson Hsieh 2021-11-19 08:14:20 PST 
Comment on attachment 444795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444795&action=review

> Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:366
> +        callOnMainRunLoop([weakThis = WeakPtr { *this }, completionHandler = WTFMove(completionHandler), error = WebCore::ResourceError { WebCore::ResourceError::Type::General }] () mutable {

Nit - might be simpler as `completionHandler(makeUnexpected(WebCore::ResourceError { WebCore::ResourceError::Type::General }));`, instead of copying the error via block capture.

> Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:397
> +    callOnMainRunLoop([weakThis = WeakPtr { *this }, completionHandler = WTFMove(completionHandler)] () mutable {

Same question as the other patch — could we clarify why we need these `callOnMainRunLoop`s?
Comment 4 Antoine Quint 2021-11-19 09:59:15 PST 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 444795 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444795&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:366
> > +        callOnMainRunLoop([weakThis = WeakPtr { *this }, completionHandler = WTFMove(completionHandler), error = WebCore::ResourceError { WebCore::ResourceError::Type::General }] () mutable {
> 
> Nit - might be simpler as
> `completionHandler(makeUnexpected(WebCore::ResourceError {
> WebCore::ResourceError::Type::General }));`, instead of copying the error
> via block capture.

Absolutely, will fix when landing.

> > Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:397
> > +    callOnMainRunLoop([weakThis = WeakPtr { *this }, completionHandler = WTFMove(completionHandler)] () mutable {
> 
> Same question as the other patch — could we clarify why we need these
> `callOnMainRunLoop`s?

I think we only need those when using block-based APIs, will remove the use of `callOnMainRunLoop()` when landing.
Comment 5 Antoine Quint 2021-11-19 10:22:11 PST 
Committed r286066 (244453@main): <https://commits.webkit.org/244453@main>