Summary: | Web Inspector: Console execution context can become an unexpected selection on refresh/navigation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick Angle <pangle> | ||||||
Component: | Web Inspector | Assignee: | Patrick Angle <pangle> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Patrick Angle
2021-11-18 18:25:37 PST
Created attachment 444767 [details]
Patch v1.0
Comment on attachment 444767 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=444767&action=review r=me, nice catch :) > Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:400 > this._restoreSelectedExecutionContextForFrame = null; Style: I'd add a newline after this > Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:401 > + this._useExecutionContextOfInspectedNode = InspectorBackend.hasDomain("DOM"); NIT: We should probably make a `_canUseExecutionContextOfInspectedNode()` or something since this is done so often. Created attachment 445638 [details]
Patch v1.1 - Address review nits
Committed r286412 (244758@main): <https://commits.webkit.org/244758@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445638 [details]. |