Bug 233253

Summary: [GLIB] jsc_value_object_define_property_accessor() throws an exception when called on a value without a wrapper instance
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2021-11-17 06:51:15 PST
We assumed that getter and setter were always methods, so we always try to set the initial parameter as the instance. When called with a value ot having an instance we get an exception because the expected instance is nullptr.
Attachments
Patch (20.47 KB, patch)
2021-11-17 06:55 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-11-17 06:55:36 PST
Created attachment 444514 [details] Patch
Michael Catanzaro
Comment 2 2021-11-17 07:43:34 PST
Comment on attachment 444514 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444514&action=review Nice tests. > Source/JavaScriptCore/ChangeLog:9 > + instance. When called with a value ot having an instance we get an exception because the expected instance is not
Carlos Garcia Campos
Comment 3 2021-11-18 01:26:11 PST
Committed r285988 (244385@main): <https://commits.webkit.org/244385@main>
Radar WebKit Bug Importer
Comment 4 2021-11-18 01:27:21 PST
<rdar://problem/85540530>
Note You need to log in before you can comment on or make changes to this bug.