| Summary: | Add support for rvfc to MediaPlayerPrivateMediaSourceAVFObjC | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, pnormand, sergio, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 231945 | ||||||||||
| Bug Blocks: | 211945, 233306 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2021-11-16 04:34:12 PST
Created attachment 444378 [details]
Patch
Created attachment 444676 [details]
Patch
Created attachment 444677 [details]
Patch
Ping review Committed r286305 (244664@main): <https://commits.webkit.org/244664@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444677 [details]. Comment on attachment 444677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444677&action=review > Source/WebCore/ChangeLog:11 > + We only enable the test if mediaSourceInlinePaintingEnabled is true since canvas painting does not work otherwise. on ports enabling the GPUProcess or on all ports? Comment on attachment 444677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444677&action=review >> Source/WebCore/ChangeLog:11 >> + We only enable the test if mediaSourceInlinePaintingEnabled is true since canvas painting does not work otherwise. > > on ports enabling the GPUProcess or on all ports? On Cocoa ports enabling GPUProcess only. You might want to tweak InternalSettings::mediaSourceInlinePaintingEnabled() or the test itself for GTK/WPE ports once you have rvfc support. |