Bug 233186

Summary: Add support for rvfc to MediaPlayerPrivateMediaSourceAVFObjC
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, pnormand, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 231945    
Bug Blocks: 211945, 233306    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

youenn fablet
Reported 2021-11-16 04:34:12 PST
Add support for rvfc to MediaPlayerPrivateMediaSourceAVFObjC
Attachments
Patch (9.93 KB, patch)
2021-11-16 07:35 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (11.66 KB, patch)
2021-11-18 08:00 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (11.75 KB, patch)
2021-11-18 08:07 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-11-16 07:35:42 PST
Created attachment 444378 [details] Patch
youenn fablet
Comment 2 2021-11-18 08:00:41 PST
Created attachment 444676 [details] Patch
youenn fablet
Comment 3 2021-11-18 08:07:10 PST
Created attachment 444677 [details] Patch
Radar WebKit Bug Importer
Comment 4 2021-11-23 04:35:23 PST
<rdar://problem/85699161>
youenn fablet
Comment 5 2021-11-30 01:31:03 PST
Ping review
EWS
Comment 6 2021-11-30 10:15:54 PST
Committed r286305 (244664@main): <https://commits.webkit.org/244664@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444677 [details].
Philippe Normand
Comment 7 2021-11-30 10:48:02 PST
Comment on attachment 444677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444677&action=review > Source/WebCore/ChangeLog:11 > + We only enable the test if mediaSourceInlinePaintingEnabled is true since canvas painting does not work otherwise. on ports enabling the GPUProcess or on all ports?
youenn fablet
Comment 8 2021-12-01 00:33:07 PST
Comment on attachment 444677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444677&action=review >> Source/WebCore/ChangeLog:11 >> + We only enable the test if mediaSourceInlinePaintingEnabled is true since canvas painting does not work otherwise. > > on ports enabling the GPUProcess or on all ports? On Cocoa ports enabling GPUProcess only. You might want to tweak InternalSettings::mediaSourceInlinePaintingEnabled() or the test itself for GTK/WPE ports once you have rvfc support.
Philippe Normand
Comment 9 2021-12-03 08:04:57 PST
https://bugs.webkit.org/show_bug.cgi?id=233813
Note You need to log in before you can comment on or make changes to this bug.