Bug 233175

Summary: RemoteGraphicsContextGLProxyBase should not have platform-specific implementations
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, Hironori.Fujii, jer.noble, kbr, kkinnunen, koivisto, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 233123    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch for landing none

Description Kimmo Kinnunen 2021-11-16 00:24:03 PST 
RemoteGraphicsContextGLProxyBase should not have platform-specific implementations
It is a simple class mostly existing for no good reason
The concrete class RemoteGraphicsContextGLProxy has Cocoa and WC implementations. The platform-specific code should move there.
Comment 1 Kimmo Kinnunen 2021-11-16 01:02:17 PST 
Created attachment 444353 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-11-16 01:25:11 PST 
Created attachment 444356 [details]
Patch
Comment 3 Kimmo Kinnunen 2021-11-16 01:58:21 PST 
Created attachment 444359 [details]
Patch
Comment 4 Kimmo Kinnunen 2021-11-16 03:41:26 PST 
Created attachment 444369 [details]
Patch
Comment 5 Antti Koivisto 2021-11-16 06:27:32 PST 
Comment on attachment 444369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444369&action=review

> Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in:1
> +´# Copyright (C) 2020 Apple Inc. All rights reserved.

Some junk here.
Comment 6 Kimmo Kinnunen 2021-11-16 23:38:11 PST 
Created attachment 444484 [details]
Patch for landing
Comment 7 EWS 2021-11-18 01:49:52 PST 
Committed r285990 (244387@main): <https://commits.webkit.org/244387@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444484 [details].
Comment 8 Radar WebKit Bug Importer 2021-11-18 01:50:26 PST 
<rdar://problem/85541122>