| Summary: | [WebGPU] Fix namespace comments | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2021-11-15 21:50:33 PST
Created attachment 444344 [details]
Patch
Created attachment 444345 [details]
Patch
Comment on attachment 444345 [details]
Patch
Sure.
Why is WebGPU inside namespace PAL at all?
Comment on attachment 444345 [details]
Patch
You may consider using C++17 nested namespace syntax to completely remove this instead.
namespace PAL::WebGPU {
...
} // namespace PAL::WebGPU
(In reply to Alex Christensen from comment #3) > Comment on attachment 444345 [details] > Patch > > Sure. > Why is WebGPU inside namespace PAL at all? This part of the WebGPU implementation is in pal/graphics/WebGPU, so I assumed that means it should get the PAL namespace. The parts that are in WebGPU.framework won't use the PAL namespace. Committed r285879 (244305@main): <https://commits.webkit.org/244305@main> |