Bug 233145

Summary: Decoder::unwrapForTesting() is unnecessarily inefficient
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ggaren, kkinnunen, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2021-11-15 13:56:11 PST 
Decoder::unwrapForTesting() is unnecessarily inefficient.
Comment 1 Chris Dumez 2021-11-15 13:58:53 PST 
Created attachment 444303 [details]
Patch
Comment 2 Darin Adler 2021-11-15 17:49:27 PST 
Comment on attachment 444303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444303&action=review

> Source/WebKit/Platform/IPC/Decoder.cpp:146
> +    Vector<Attachment> attachments = std::exchange(decoder.m_attachments, { });

I would totally use auto here.

> Source/WebKit/Platform/IPC/Decoder.h:137
> +    std::optional<Attachment> takeAttachment();

Why isn’t this named takeLastAttachment? Is it obvious that the last one is the one to take?
Comment 3 Chris Dumez 2021-11-16 07:12:56 PST 
Created attachment 444374 [details]
Patch
Comment 4 EWS 2021-11-16 08:58:02 PST 
Committed r285866 (244292@main): <https://commits.webkit.org/244292@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444374 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-16 08:59:33 PST 
<rdar://problem/85460462>