| Summary: | Fingers down on the trackpad should stop an animated scroll | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Scrolling | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2021-11-14 18:01:47 PST
Created attachment 444202 [details]
Patch
Comment on attachment 444202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444202&action=review > Source/WebCore/platform/mac/ScrollingEffectsController.mm:143 > + return true; Is returning `true` correct for the `PlatformWheelEventPhase::Cancelled` case as well? (In reply to Wenson Hsieh from comment #2) > Comment on attachment 444202 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444202&action=review > > > Source/WebCore/platform/mac/ScrollingEffectsController.mm:143 > > + return true; > > Is returning `true` correct for the `PlatformWheelEventPhase::Cancelled` > case as well? There's no clear logic behind saying that MayBegin and Cancelled are handled so it's fuzzy. Committed r285797 (244241@main): <https://commits.webkit.org/244241@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444202 [details]. |