Bug 233100
| Summary: | Rather than hardcoding which settings are overrided by CaptivePortalModeEnabled, it should be controlled by a new field in the WebPreferences* yaml files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | cdumez, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
Rather than hardcoding which settings are overrided by CaptivePortalModeEnabled, it should be controlled by a new field in the WebPreferences* yaml files. This would be more future proof and allow easier refactoring and stick with the general philosophy of making as much of the settings code as possible declarative.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/85647258>
Ryosuke Niwa
I've done that in https://commits.webkit.org/281949@main.