Bug 233062

Summary:

webView._isBeingInspected does not work with Service Worker pages

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, pangle, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Timothy Hatcher 2021-11-12 13:14:03 PST

When a service worker is loaded in a Page, we need to report its inspector frontend count up to the page's inspectorController so the client knows about it.

Comment 1 Radar WebKit Bug Importer 2021-11-12 13:14:21 PST

<rdar://problem/85354982>

Comment 2 Timothy Hatcher 2021-11-12 13:15:47 PST

Created attachment 444096 [details]
Patch

Comment 3 Devin Rousso 2021-11-12 18:07:08 PST

Comment on attachment 444096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444096&action=review

r=me

> Source/WebCore/inspector/WorkerInspectorController.cpp:140
> +#if ENABLE(SERVICE_WORKER)

Style: I'd add a newline after this

> Source/WebCore/inspector/WorkerInspectorController.cpp:160
> +#endif

Style: i'd add a newline before this and `// ENABLE(SERVICE_WORKER)`

Comment 4 Timothy Hatcher 2021-11-12 19:18:56 PST

Comment on attachment 444096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444096&action=review

>> Source/WebCore/inspector/WorkerInspectorController.cpp:140
>> +#if ENABLE(SERVICE_WORKER)
> 
> Style: I'd add a newline after this

Other places in the code don't do this, so I'll leave it as-is.

Comment 5 EWS 2021-11-12 19:22:21 PST

Committed r285771 (244215@main): <https://commits.webkit.org/244215@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444096 [details].