Bug 233040 – Some C++ source files use #pragma once

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adrian Perez]

Given that “#pragma once” is intended to be used only in headers (or, more
precisely, in files that get “#include”'d), it does not make sense to make
use of it inside implementation .cpp files, yet it is present in a few:

  % rg --files-with-matches --glob '*.cpp' '^#pragma once' Source/ 
  Source/WebKit/WebProcess/WebCoreSupport/WebCaptionPreferencesDelegate.cpp
  Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp
  Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp
  Source/WebCore/Modules/WebGPU/GPUQueue.cpp
  Source/WebCore/Modules/WebGPU/GPUQuerySet.cpp
  Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.cpp
  Source/WebCore/Modules/WebGPU/GPUCommandEncoder.cpp
  Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
  Source/WebCore/page/PerformanceNavigationTiming.cpp
  %

At least GCC 11.1 will warn about these spurious uses.

[Adrian Perez]

Created attachment 444061 [details]
Patch

[Adrian Perez]

Thanks cdumez! The build failure from the mac-wk1 is unrelated, that
queue seems to be having trouble lately, so I'll go ahead and mark
this cq+ :)

[Chris Dumez]

(In reply to Adrian Perez from comment #2)
> Thanks cdumez! The build failure from the mac-wk1 is unrelated, that
> queue seems to be having trouble lately, so I'll go ahead and mark
> this cq+ :)

Yes, I filed https://bugs.webkit.org/show_bug.cgi?id=233043 and skipped that test due to all these ews mac-wk1 false positives.

[EWS]

Committed r285724 (244183@main): <https://commits.webkit.org/244183@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444061 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85344690>

[Myles C. Maxfield]

Thanks for fixing this!!!

[Adrian Perez]

(In reply to Myles C. Maxfield from comment #6)
> Thanks for fixing this!!!

No problem at all :)