Bug 233034

Summary: [JSC][32bit] Unskip JSTests/microbenchmarks/redefine-property-accessor-dictionary.js
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, xan.lopez
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
v1
ews-feeder: commit-queue-
v2 none

Xan Lopez
Reported 2021-11-12 02:56:06 PST
This is skipped for memoryLimited *and* mips|arm systems, but a) seems to run fine on both setups and b) is almost identical to the other tests/benchmarks that landed in the same patch, that do not have that limitation. Optimistically remove the skip and let's see if it sticks.
Attachments
v1 (2.23 KB, patch)
2021-11-12 02:57 PST, Xan Lopez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
v2 (2.22 KB, patch)
2021-11-12 03:13 PST, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2021-11-12 02:57:25 PST
Created attachment 444054 [details] v1
EWS
Comment 2 2021-11-12 02:58:15 PST
ChangeLog entry in JSTests/ChangeLog contains OOPS!.
Xan Lopez
Comment 3 2021-11-12 03:13:46 PST
Created attachment 444056 [details] v2 Mark it as gardening!
EWS
Comment 4 2021-11-12 03:43:34 PST
Committed r285712 (244171@main): <https://commits.webkit.org/244171@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444056 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-12 03:44:20 PST
<rdar://problem/85337961>
Note You need to log in before you can comment on or make changes to this bug.