Bug 233010

Summary:

Move subtree update logic in ImageOverlay::updateWithTextRecognitionResult() into a separate helper

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Platform

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akeerthi, cdumez, esprehn+autocc, ews-watchlist, hi, kangil.han, megan_gardner, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Depends on #232974	none

Wenson Hsieh

Reported 2021-11-11 13:10:02 PST

Attachments
Depends on #232974 (12.38 KB, patch) 2021-11-11 13:24 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2021-11-11 13:24:21 PST

Created attachment 443996 [details] Depends on #232974

Wenson Hsieh

Comment 2 2021-11-11 18:10:19 PST

Comment on attachment 443996 [details] Depends on #232974 The flaky test failure (fast/dom/Geolocation/cached-position-iframe.html) seems unrelated.

Wenson Hsieh

Comment 3 2021-11-12 08:49:06 PST

Comment on attachment 443996 [details] Depends on #232974 Thanks for the review!

EWS

Comment 4 2021-11-12 08:52:27 PST

Committed r285725 (244184@main): <https://commits.webkit.org/244184@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443996 [details].

Radar WebKit Bug Importer

Comment 5 2021-11-12 08:53:21 PST

Note You need to log in before you can comment on or make changes to this bug.