Bug 23300 – Selection functions should throw exceptions when used on buttons

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Mads Ager]

Firefox throws exceptions when using selection functions on HTMLInputElements that do not support selection.  Maybe WebKit should to?

Patch on its way.

[Mads Ager]

Created attachment 26680 [details]
Patch

[Sam Weinig]

Are there any known sites that require this?

[Mads Ager]

(In reply to comment #2)
> Are there any known sites that require this?

Not that I know of, no.

As far as I can tell, we have tried to be compatible with Firefox here. The selection-function test seemed to pass on Firefox but only because it throws exceptions along the way.

I like the fact that this gets rid of the custom getOwnPropertySlot implementation.  Come to think of it, that custom implementation will get in the way of changes to setSelectionRange on buttons:

  HTMLInputElement.prototype.setSelectionRange = function(){};
  var b = document.getElementById("button");
  b.setSelectionRange;   // <--- undefined

Also, returning undefined will probably lead to exceptions throw in the code anyway since people will most likely try to call the function or use the value of the attributes?

[Sam Weinig]

What does IE do?  I am always hesitant to throw exceptions as they can often break un-expecting scripts.

[Mads Ager]

IE does not support the selection attributes and functions on HTMLInputElements.  Therefore, I think that Firefox compatibility should be the goal for these functions. 

[Darin Adler]

This takes care of the getter for selectionStart, for selectionEnd, and the function setSelectionRange. What about the setters for selectionStart and selectionEnd? Is it appropriate for them to silently do nothing, or should they be throwing exceptions too?

[Mads Ager]

Good point, thanks!  The setters should be throwing exceptions as well.  I'll upload an updated patch ASAP.

[Mads Ager]

Created attachment 26768 [details]
Updated to throw exceptions in selectionStart and selectionEnd setters

[Mads Ager]

Darin and Sam, could one of you guys have a look at this again?  Thanks.

[Darin Adler]

Comment on attachment 26768 [details]
Updated to throw exceptions in selectionStart and selectionEnd setters

r=me

[Dimitri Glazkov (Google)]

Committed in http://trac.webkit.org/changeset/40293