| Summary: | Upstream some of platform/graphics/chromium | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Dimitri Glazkov (Google)
2009-01-13 11:21:01 PST
Created attachment 26676 [details]
add a few font-related files
.../graphics/chromium/FontCustomPlatformData.cpp | 232 ++++++++++++++++++++
.../graphics/chromium/FontCustomPlatformData.h | 70 ++++++
WebCore/platform/graphics/chromium/FontLinux.cpp | 111 ++++++++++
.../platform/graphics/chromium/FontPlatformData.h | 43 ++++
4 files changed, 456 insertions(+), 0 deletions(-)
Comment on attachment 26676 [details]
add a few font-related files
Looks good except for:
#ifndef FontPlatformData_h
32 #define FontPlatformData_h
33
34 #include "config.h"
35 #include "build/build_config.h"
36
37 #if defined(OS_WIN)
38 #include "FontPlatformDataChromiumWin.h"
39 #elif defined(OS_LINUX)
40 #include "FontPlatformDataLinux.h"
41 #endif
42
We never include config.h in a header. And I would think we should use WebCore equivilents to the OS_ defines, like PLATFORM(WIN_OS) and defined(__linux__) (since we don't seem to have a PLATFORM(LINUX). Otherwise you're good to land.
Comments addressed and committed in http://trac.webkit.org/changeset/39875 |