Bug 232956

Summary: [AX] Stop creating sandbox extensions for preference services
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cfleizach, gavin.p, ggaren, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236248
Bug Depends on:    
Bug Blocks: 231068    
Attachments:
Description Flags
Patch
none
Patch
ggaren: review+
Patch none

Description Per Arne Vollan 2021-11-10 10:39:24 PST 
Stop creating sandbox extensions for preference services when AX is enabled. There has been many code changes related to updating AX preferences in the WebContent process, which is why we think this is not needed anymore.
Comment 1 Radar WebKit Bug Importer 2021-11-10 10:39:58 PST 
<rdar://problem/85260698>
Comment 2 Per Arne Vollan 2021-11-10 10:42:04 PST 
Created attachment 443836 [details]
Patch
Comment 3 chris fleizach 2021-11-10 10:51:58 PST 
Comment on attachment 443836 [details]
Patch

might be good to get a root tested for this one. I agree this should be ok based on what we've done lately, but hard to guarantee
Comment 4 Per Arne Vollan 2022-02-04 09:07:47 PST 
Created attachment 450904 [details]
Patch
Comment 5 Geoffrey Garen 2022-02-04 09:11:36 PST 
Comment on attachment 450904 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450904&action=review

r=me

> Source/WebKit/ChangeLog:9
> +        Stop creating sandbox extensions for preference services when AX is enabled. There has been many code changes

has been => have been
Comment 6 Per Arne Vollan 2022-02-04 09:34:12 PST 
(In reply to Geoffrey Garen from comment #5)
> Comment on attachment 450904 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450904&action=review
> 
> r=me
> 
> > Source/WebKit/ChangeLog:9
> > +        Stop creating sandbox extensions for preference services when AX is enabled. There has been many code changes
> 
> has been => have been

Will fix!

Thanks for reviewing!
Comment 7 Per Arne Vollan 2022-02-04 09:36:11 PST 
Created attachment 450907 [details]
Patch
Comment 8 EWS 2022-02-04 19:32:09 PST 
Committed r289147 (246843@main): <https://commits.webkit.org/246843@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450907 [details].