| Summary: | WebKit r39852 crashes on launch | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Craig W. Cadwallader <bugzilla> | ||||||||||||
| Component: | JavaScriptCore | Assignee: | Gavin Barraclough <barraclough> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Critical | CC: | barraclough, barton.tyner, shawnzone, webkit | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Mac | ||||||||||||||
| OS: | OS X 10.5 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Craig W. Cadwallader
2009-01-13 07:39:47 PST
Created attachment 26668 [details]
crash report text
*** Bug 23299 has been marked as a duplicate of this bug. *** Created attachment 26679 [details] crash report for r39851 crash on launch r39851 meant this comment - r39839 does NOT crash on launch - with Comment #3 but got cut off when attaching report - sorry: *** Bug 23301 has been marked as a duplicate of this bug. *** (In reply to comment #4) > meant this comment - r39839 does NOT crash on launch - with Comment #3 but got > cut off when attaching report - sorry: > Reference is to r39851 and r39872, DO Crash upon launch. Reproducible. Sent crash log, I'm new to Bugzilla, not Webkit nightlies used as the primary browser. r39839 does NOT crash upon launch. I reverted. Created attachment 26686 [details] The patch Yep, I seem to have broken the interpreter pretty nastily in r39851. Created attachment 26687 [details]
The other patch
Gah, - platform.h change.
Comment on attachment 26687 [details]
The other patch
r=me
Why not & rather than &&?
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/runtime/JSImmediate.h Transmitting file data .. Committed revision 39879. Created attachment 26701 [details] crash report for r39872 crash on launch continues with r39872 (see attached crash report) Should this be entered as new bug report? Craig, This should be fixed in revision r39879. If you see crashes on r39879 or above, please reopen this bug and check it's assigned to me, & I'll fix. But fingers crossed, I think all platforms should now be good. Many thanks, Gavin. (In reply to comment #13) > Craig, > > This should be fixed in revision r39879. If you see crashes on r39879 or > above, please reopen this bug and check it's assigned to me, & I'll fix. But > fingers crossed, I think all platforms should now be good. > > Many thanks, > Gavin. > Resolved (In reply to comment #13) > Craig, > > This should be fixed in revision r39879. If you see crashes on r39879 or > above, please reopen this bug and check it's assigned to me, & I'll fix. But > fingers crossed, I think all platforms should now be good. > > Many thanks, > Gavin. > Gavin, r39879 wasn't posted to the nightlies list but r39881 and r39882 are and the problem is resolved. Thanks! Craig *** Bug 23293 has been marked as a duplicate of this bug. *** |