Summary: | Enable dialog tests on Windows | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> | ||||||
Component: | Tools / Tests | Assignee: | Tim Nguyen (:ntim) <ntim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 232926 | ||||||||
Bug Blocks: | 84635 | ||||||||
Attachments: |
|
Description
Tim Nguyen (:ntim)
2021-11-09 15:59:59 PST
Created attachment 443744 [details]
Patch
Created attachment 443776 [details]
Patch
Comment on attachment 443776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443776&action=review > Source/WebCore/page/RuntimeEnabledFeatures.h:295 > + bool m_dialogElementEnabled { true }; It does not seem a runtime flag is needed here. Can we instead move from a runtime flag to a settings in WebPreferencesExperimental? (In reply to youenn fablet from comment #3) > Comment on attachment 443776 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443776&action=review > > > Source/WebCore/page/RuntimeEnabledFeatures.h:295 > > + bool m_dialogElementEnabled { true }; > > It does not seem a runtime flag is needed here. > Can we instead move from a runtime flag to a settings in > WebPreferencesExperimental? It already exists: https://webkit-search.igalia.com/webkit/source/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml#439-451 Comment on attachment 443776 [details]
Patch
It would be nice to move to a Settings, can we file a bug to track this one?
Committed r285569 (244077@main): <https://commits.webkit.org/244077@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443776 [details]. |