Summary: | [Monterey] TestWebKitAPI.PrivateClickMeasurement.Daemon* tests timing out: Failed to connect to mach service org.webkit.pcmtestdaemon.service | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, beidson, cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2021-11-09 09:57:37 PST
OSLaunchdJob.submit is returning this error: Error Domain=OSLaunchdErrorDomain Code=144 "Requestor lacks required entitlement" UserInfo={NSLocalizedFailureReason=Requestor lacks required entitlement} Relevant, from building: Code Signing Warning: "TestWebKitAPI" isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. *** Bug 234482 has been marked as a duplicate of this bug. *** Created attachment 447533 [details]
Patch
Comment on attachment 447533 [details]
Patch
You made the changes to both adattributiond and webpushd tests, but left the webpush tests disabled.
Could you enable them and go through another EWS pass? R+ with that.
Comment on attachment 447533 [details]
Patch
They seem to need some more work to get them working, though I'm confident this was a step in the right direction.
Committed r287234 (245394@main): <https://commits.webkit.org/245394@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447533 [details]. |