| Summary: | Convert more wheel event tests to UIHelper.mouseWheelSequence() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ntim, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2021-11-08 13:43:12 PST
Created attachment 443598 [details]
Patch
Comment on attachment 443598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443598&action=review You can simplify the code in ui-helper.js > LayoutTests/resources/ui-helper.js:111 > + static async mouseWheelSequence(eventStream, options) static async mouseWheelSequence(eventStream, { waitForCompletion = true }) > LayoutTests/resources/ui-helper.js:119 > + const waitForScrollCompletion = options?.waitForCompletion ?? true; > + if (waitForScrollCompletion) if (waitForCompletion) > LayoutTests/resources/ui-helper.js:132 > + if (waitForScrollCompletion) ditto Comment on attachment 443598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443598&action=review > LayoutTests/fast/scrolling/mac/momentum-axis-locking.html:162 > + await UIHelper.mouseWheelSequence({ events: events }); here and below: { events: events } -> { events } works as well Comment on attachment 443598 [details]
Patch
r=me (with Tim's suggestions)
Created attachment 443604 [details]
Patch
|