Bug 232842

Summary: [GPU Process] [Filters 20/23] Simplify the dynamic update of the SVG filter elements
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, ryuan.choi, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 241535, 246602    
Bug Blocks: 231253    
Attachments:
Description Flags
WIP
none
Patch ews-feeder: commit-queue-

Said Abou-Hallawa
Reported 2021-11-08 13:17:15 PST
Since the FilterEffect does not own the result FilterImage or the geometry FilterBoundarySet, all the superclasses of SVGFilterPrimitiveStandardAttributes should have a singleton FilterEffect for all the renderers. Changing an attribute of these classes should be resulting in changing a member of the singleton FilterEffect. And of course we need to clear some of the the result FilterImages which are owned by the renderers.
Attachments
WIP (142.81 KB, patch)
2022-04-18 01:20 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (149.81 KB, patch)
2022-04-30 18:13 PDT, Said Abou-Hallawa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-15 13:20:36 PST
<rdar://problem/85426197>
Said Abou-Hallawa
Comment 2 2022-04-18 01:20:03 PDT
Created attachment 457801 [details] WIP
Said Abou-Hallawa
Comment 3 2022-04-30 18:13:24 PDT
Created attachment 458641 [details] Patch
Said Abou-Hallawa
Comment 4 2022-06-10 02:45:51 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1441
EWS
Comment 5 2022-06-13 12:53:19 PDT
Committed r295498 (251503@main): <https://commits.webkit.org/251503@main> Reviewed commits have been landed. Closing PR #1441 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.