JSImmediate should be private.

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Gavin Barraclough]

JSImmediate  exposes the internal implementation of JSValuePtr, and commonly there are multiple interfaces that can be used to achieve the same effect.  We should rationalize down the interfaces, and move all operations on JSValuePtrs to use the interface provided by JSValuePtr.

[Gavin Barraclough]

Created attachment 26658 [details]
The patch

[Oliver Hunt]

Comment on attachment 26658 [details]
The patch


JavaScriptCore/API/JSCallbackObjectFunctions.h

@@ double JSCallbackObject<Base>::toNumber(
378378         if (JSObjectConvertToTypeCallback convertToType = jsClass->convertToType) {
379379             JSLock::DropAllLocks dropAllLocks(exec);
380380             if (JSValueRef value = convertToType(ctx, thisRef, kJSTypeNumber, toRef(exec->exceptionSlot())))
381                  return toJS(value)->getNumber();
 381                 return toJS(value)->uncheckedGetNumber();
382382         }
383383             
384384     return Base::toNumber(exec);

This isn't safe -- convertToType is developer defined so we can't guarantee good behaviour, so this can't be unchecked, i think

double dValue;
return toJS(value)->getNumber(dValue) ? dValue : NaN;

Would be the correct version

Otherwise r=me

[Gavin Barraclough]

Review comment fixerated.

Transmitting file data ......................................
Committed revision 39851.

[Darin Adler]

This is a great change. I've been hoping to see this for *ages*. Thanks, Gavin!