Summary: | Fix the Chromium Win build | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, darin, eric, mjs | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Dmitry Titov
2009-01-12 18:45:39 PST
PLATFORM(WIN) indicates a port using high-level Windows functionality, such as GDI and so on, while WIN_OS indicates low-level functionality such as threading primitives. Neither indicates which port is being built. (In reply to comment #1) > PLATFORM(WIN) indicates a port using high-level Windows functionality, such as > GDI and so on, while WIN_OS indicates low-level functionality such as threading > primitives. Neither indicates which port is being built. > There has been historical disagreement on this point. It would be very useful to me (and likely others) if you, or someone else from the project could post to webkit-dev or write on the wiki what each of the PLATFORM(*) defines mean. Created attachment 26659 [details]
Proposed patch
bdash: thanks! It seems that for time querying purposes, the WIN_OS is the right one... So here is the patch.
The change affects only Chromium builds since they are PLATFORM(CHROMIUM) && PLATFORM(WIN_OS) which was not covered before.
WIN, GTK, QT and WX stay the same. The only reason for GTK and WX to be here is to match occasional usage of their time getters.
(In reply to comment #2) > (In reply to comment #1) > > PLATFORM(WIN) indicates a port using high-level Windows functionality, such as > > GDI and so on, while WIN_OS indicates low-level functionality such as threading > > primitives. Neither indicates which port is being built. > > > > There has been historical disagreement on this point. It would be very useful > to me (and likely others) if you, or someone else from the project could post > to webkit-dev or write on the wiki what each of the PLATFORM(*) defines mean. This has been discussed *at length* on webkit-dev in the past. Comment on attachment 26659 [details]
Proposed patch
r=me
Committed: http://trac.webkit.org/changeset/39866 |