Bug 232766

Summary: Lookup for text would not show after clicking the page and using key commands to launch.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mifenton, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Megan Gardner 2021-11-05 14:44:49 PDT 
Lookup for text would not show after clicking the page and using key commands to launch.
Comment 1 Megan Gardner 2021-11-05 15:00:52 PDT 
Created attachment 443440 [details]
Patch
Comment 2 Megan Gardner 2021-11-05 15:01:19 PDT 
rdar://74562619
Comment 3 Wenson Hsieh 2021-11-05 15:03:48 PDT 
Comment on attachment 443440 [details]
Patch

r=mews
Comment 4 Tim Horton 2021-11-05 16:02:01 PDT 
Comment on attachment 443440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443440&action=review

> Source/WebCore/ChangeLog:13
> +        The solution was to set ignoreSelectionChanges on the temporary selection, and also to stop propagating temporary selection changes to accessibly, as 

"accessibly" -> accessibility

> Source/WebCore/ChangeLog:14
> +        that should not be necessary and that is the code that cause a sync message to be sent to the UI process while it was sync awaiting our reply for the

might be good to mention the name of the outgoing message (maybe just in the bug, or here) for posterity's sake.
Comment 5 Megan Gardner 2021-11-05 21:22:23 PDT 
Created attachment 443475 [details]
Patch for landing
Comment 6 EWS 2021-11-05 21:49:55 PDT 
Committed r285365 (243923@main): <https://commits.webkit.org/243923@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443475 [details].