Bug 232765

Summary: [git-webkit] Open closed pull-request when running pr
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2021-11-05 13:39:52 PDT
When we run `git-webkit pr`, if we match a closed pull-request, we should re-open that pull-request.
Attachments
Patch (10.29 KB, patch)
2021-11-05 13:43 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (12.34 KB, patch)
2021-11-08 14:44 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-05 13:40:12 PDT
<rdar://problem/85084318>
Jonathan Bedard
Comment 2 2021-11-05 13:43:51 PDT
Created attachment 443433 [details] Patch
Alexey Proskuryakov
Comment 3 2021-11-08 10:33:09 PST
Comment on attachment 443433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443433&action=review > Tools/ChangeLog:3 > + [git-webkit] Open closed pull-request when running pr Should the script ask the user for confirmation? This is likely to be in error, so doing it unconditionally seems questionable.
Jonathan Bedard
Comment 4 2021-11-08 14:44:00 PST
Created attachment 443610 [details] Patch
Jonathan Bedard
Comment 5 2021-11-08 14:49:16 PST
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 443433 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443433&action=review > > > Tools/ChangeLog:3 > > + [git-webkit] Open closed pull-request when running pr > > Should the script ask the user for confirmation? This is likely to be in > error, so doing it unconditionally seems questionable. Updated the patch to prompt the user if the pull-request is closed. We also need to match opened pull-requests by default if we're going to prompt users to duplicate branch names in PRs. As a side note, https://github.com/WebKit/WebKit/pull/35 is the pull-request for this change.
Jonathan Bedard
Comment 6 2021-11-12 11:23:59 PST
Comment on attachment 443610 [details] Patch Landed https://commits.webkit.org/244192@main (r 285733)
Jonathan Bedard
Comment 7 2021-11-12 11:24:27 PST
Landed https://commits.webkit.org/244192@main (r285733)
Jonathan Bedard
Comment 8 2022-01-04 07:28:01 PST
Follow-up fix: https://github.com/WebKit/WebKit/pull/60
Note You need to log in before you can comment on or make changes to this bug.