[git-webkit] Open closed pull-request when running pr

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

When we run `git-webkit pr`, if we match a closed pull-request, we should re-open that pull-request.

[Radar WebKit Bug Importer]

<rdar://problem/85084318>

[Jonathan Bedard]

Created attachment 443433 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 443433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443433&action=review

> Tools/ChangeLog:3
> +        [git-webkit] Open closed pull-request when running pr

Should the script ask the user for confirmation? This is likely to be in error, so doing it unconditionally seems questionable.

[Jonathan Bedard]

Created attachment 443610 [details]
Patch

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 443433 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443433&action=review
> 
> > Tools/ChangeLog:3
> > +        [git-webkit] Open closed pull-request when running pr
> 
> Should the script ask the user for confirmation? This is likely to be in
> error, so doing it unconditionally seems questionable.

Updated the patch to prompt the user if the pull-request is closed. We also need to match opened pull-requests by default if we're going to prompt users to duplicate branch names in PRs.

As a side note, https://github.com/WebKit/WebKit/pull/35 is the pull-request for this change.

[Jonathan Bedard]

Comment on attachment 443610 [details]
Patch

Landed https://commits.webkit.org/244192@main (r 285733)

[Jonathan Bedard]

Landed https://commits.webkit.org/244192@main (r285733)

[Jonathan Bedard]

Follow-up fix:
https://github.com/WebKit/WebKit/pull/60