Bug 23276

Summary: warning in CSSFontSelector.cpp
Product: WebKit Reporter: scroggo
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: caryclark, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Remove a warning none

scroggo
Reported 2009-01-12 14:33:07 PST
Our compiler gives a warning on CSSFontSelector.cpp.
Attachments
Remove a warning (1.41 KB, patch)
2009-01-12 14:58 PST, scroggo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2009-01-12 14:38:29 PST
Care to share a little bit more information? What is the warning message? For which line is it emitted? What is "our compiler"? Which platform are you on? A bug report with so little information isn't particularly useful.
scroggo
Comment 2 2009-01-12 14:57:38 PST
I get the following warning: CSSFontSelector.cpp: In member function 'void WebCore::CSSFontSelector::addFontFaceRule(const WebCore::CSSFontFaceRule*)': CSSFontSelector.cpp:96: warning: suggest parentheses around && within || This is building Android, which I believe uses a custom gcc 4.2.1.
scroggo
Comment 3 2009-01-12 14:58:05 PST
Created attachment 26651 [details] Remove a warning
Laszlo Gombos
Comment 4 2009-12-28 17:25:03 PST
This has been resolved as part of r42002 - see http://trac.webkit.org/changeset/42002#file1. Changing the status to FIXED.
Note You need to log in before you can comment on or make changes to this bug.