Bug 232741

Summary: record<DOMString, GPUSize64> in a dictionary doesn't seem to be supported by IDL
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: BindingsAssignee: Dan Glastonbury <djg>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, djg, esprehn+autocc, ews-watchlist, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232558    
Attachments:
Description Flags
Patch
none
Patch none

Description Myles C. Maxfield 2021-11-04 19:20:14 PDT 
See dictionary GPUDeviceDescriptor.
Comment 1 Radar WebKit Bug Importer 2021-11-11 18:21:19 PST 
<rdar://problem/85325316>
Comment 2 Dan Glastonbury 2022-03-01 20:16:41 PST 
Created attachment 453566 [details]
Patch
Comment 3 Dan Glastonbury 2022-03-01 20:21:45 PST 
Created attachment 453567 [details]
Patch
Comment 4 Myles C. Maxfield 2022-03-02 08:13:23 PST 
Comment on attachment 453567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453567&action=review

> Source/WebCore/ChangeLog:10
> +        GPUDeviceDescriptor.

I don’t see any bindings code here. Did this always work?
Comment 5 Sam Weinig 2022-03-02 10:02:38 PST 
(In reply to Myles C. Maxfield from comment #4)
> Comment on attachment 453567 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453567&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        GPUDeviceDescriptor.
> 
> I don’t see any bindings code here. Did this always work?

Myles, I think you didn't add the necessary typedef to the IDL file when you tried, so that was likely why it didn't work for you.
Comment 6 Myles C. Maxfield 2022-03-02 16:02:09 PST 
Comment on attachment 453567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453567&action=review

>>> Source/WebCore/ChangeLog:10
>>> +        GPUDeviceDescriptor.
>> 
>> I don’t see any bindings code here. Did this always work?
> 
> Myles, I think you didn't add the necessary typedef to the IDL file when you tried, so that was likely why it didn't work for you.

🥲
Comment 7 EWS 2022-03-02 16:30:29 PST 
Committed r290761 (248005@main): <https://commits.webkit.org/248005@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453567 [details].