Bug 232716

Summary: Implement FileSystemFileHandle.getFile()
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Sihui Liu 2021-11-04 10:09:50 PDT 
...
Comment 1 Radar WebKit Bug Importer 2021-11-04 10:10:19 PDT 
<rdar://problem/85022453>
Comment 2 Sihui Liu 2021-11-16 01:17:06 PST 
Created attachment 444354 [details]
Patch
Comment 3 Sihui Liu 2021-11-16 09:20:42 PST 
Created attachment 444401 [details]
Patch
Comment 4 youenn fablet 2021-11-16 10:56:38 PST 
Comment on attachment 444401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444401&action=review

> Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp:62
> +        promise.settle(File::create(context, result.returnValue(), { }, protectedThis->name()));

Should be resolve, not settle.

> Source/WebCore/fileapi/Blob.h:86
> +    static Ref<Blob> deserialize(ScriptExecutionContext* context, const URL& srcURL, const String& type, std::optional<long long> size, const String& fileBackedPath)

Why is this needed?

> Source/WebCore/platform/network/BlobRegistryImpl.cpp:235
> +        return nullptr;

Wy is this needed?
Comment 5 Sihui Liu 2021-11-16 18:15:47 PST 
Created attachment 444464 [details]
Patch for landing
Comment 6 Sihui Liu 2021-11-16 18:16:21 PST 
(In reply to youenn fablet from comment #4)
> Comment on attachment 444401 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444401&action=review
> 
> > Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp:62
> > +        promise.settle(File::create(context, result.returnValue(), { }, protectedThis->name()));
> 
> Should be resolve, not settle.
> 
> > Source/WebCore/fileapi/Blob.h:86
> > +    static Ref<Blob> deserialize(ScriptExecutionContext* context, const URL& srcURL, const String& type, std::optional<long long> size, const String& fileBackedPath)
> 
> Why is this needed?

Not needed. Removed.

> 
> > Source/WebCore/platform/network/BlobRegistryImpl.cpp:235
> > +        return nullptr;
> 
> Wy is this needed?

Not needed. Removed.
Comment 7 EWS 2021-11-16 18:55:40 PST 
Committed r285912 (244321@main): <https://commits.webkit.org/244321@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444464 [details].