Bug 232716

Summary: Implement FileSystemFileHandle.getFile()
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Sihui Liu
Reported 2021-11-04 10:09:50 PDT
...
Attachments
Patch (130.57 KB, patch)
2021-11-16 01:17 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (130.51 KB, patch)
2021-11-16 09:20 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (128.85 KB, patch)
2021-11-16 18:15 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-04 10:10:19 PDT
<rdar://problem/85022453>
Sihui Liu
Comment 2 2021-11-16 01:17:06 PST
Created attachment 444354 [details] Patch
Sihui Liu
Comment 3 2021-11-16 09:20:42 PST
Created attachment 444401 [details] Patch
youenn fablet
Comment 4 2021-11-16 10:56:38 PST
Comment on attachment 444401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444401&action=review > Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp:62 > + promise.settle(File::create(context, result.returnValue(), { }, protectedThis->name())); Should be resolve, not settle. > Source/WebCore/fileapi/Blob.h:86 > + static Ref<Blob> deserialize(ScriptExecutionContext* context, const URL& srcURL, const String& type, std::optional<long long> size, const String& fileBackedPath) Why is this needed? > Source/WebCore/platform/network/BlobRegistryImpl.cpp:235 > + return nullptr; Wy is this needed?
Sihui Liu
Comment 5 2021-11-16 18:15:47 PST
Created attachment 444464 [details] Patch for landing
Sihui Liu
Comment 6 2021-11-16 18:16:21 PST
(In reply to youenn fablet from comment #4) > Comment on attachment 444401 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444401&action=review > > > Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp:62 > > + promise.settle(File::create(context, result.returnValue(), { }, protectedThis->name())); > > Should be resolve, not settle. > > > Source/WebCore/fileapi/Blob.h:86 > > + static Ref<Blob> deserialize(ScriptExecutionContext* context, const URL& srcURL, const String& type, std::optional<long long> size, const String& fileBackedPath) > > Why is this needed? Not needed. Removed. > > > Source/WebCore/platform/network/BlobRegistryImpl.cpp:235 > > + return nullptr; > > Wy is this needed? Not needed. Removed.
EWS
Comment 7 2021-11-16 18:55:40 PST
Committed r285912 (244321@main): <https://commits.webkit.org/244321@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444464 [details].
Note You need to log in before you can comment on or make changes to this bug.