Summary: | [GTK][a11y] Add implementation of hyperlink interface when building with ATSPI | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aboxhall, andresg_22, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, mifenton, samuel_white | ||||||||
Priority: | P2 | Keywords: | Gtk | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 232300, 232622 | ||||||||||
Bug Blocks: | 230253, 232708 | ||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2021-11-04 03:47:01 PDT
Created attachment 443298 [details]
Patch
This won't apply because it depends on other bugs not fixed yet.
Created attachment 444661 [details]
Patch
Created attachment 444662 [details]
Patch
Comment on attachment 444662 [details] Patch Patch LGTM with a nit. Please apply the suggestion below before landing :) View in context: https://bugs.webkit.org/attachment.cgi?id=444662&action=review > Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:499 > + if (--index == -1) This modifies “index“ in place, which made me wonder “why, and where is the modified value used later?“. But then it's not used again at all. So I would prefer to have this check written this way for readability: if (index == 0) =) Committed r286050 (244437@main): <https://commits.webkit.org/244437@main> |