Summary: | [ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ayumi_kojima | ||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, cdumez, ddkilzer, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=231919 | ||||||||
Attachments: |
|
Description
ayumi_kojima
2021-11-03 11:56:01 PDT
According to the history, the test first crashed at r283612. This is a regression from https://trac.webkit.org/changeset/284743/webkit Created attachment 443234 [details]
Patch
Committed r285231 (243852@main): <https://commits.webkit.org/243852@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443234 [details]. So WeakPtr<>::get() is not thread-safe, even though WeakPtrImpl<> derives from ThreadSafeRefCounted. I guess that makes sense as we’d have to add locking when accessing the actual object (not just its count) to make it thread-safe. Reopening to attach new patch. Created attachment 443328 [details]
Patch
Committed r285305 (243884@main): <https://commits.webkit.org/243884@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443328 [details]. |